← All results

Narrowing an object union by a discriminating property

Group: Cross-analyzer regressions · Category: regression · File: regressions_object_property_discriminant_narrowing.php

StrBox::$v is string and IntBox::$v is int, so is_string($b->v) holds only for StrBox. In that branch $b is StrBox and return $b satisfies the : StrBox return type. Analyzers diverge on whether they narrow the *object* union from a check on a discriminating property. PHPStan narrows array-shape discriminated unions ($a['tag'] === true) but not the object equivalent (is_string($b->v) / $b->tag === true), so it keeps StrBox|IntBox here and reports a false-positive return.type. Source lead: Mago analyzer test issue_1093 (test_property_narrowing).

Analyzer results

AnalyzerVersionResultDiagnostics
phan 6.0.7Phan 6.0.7 php-ast version 1.1.3 PHP version used to run Phan: 8.5.9 Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
phpstan 2.2.11PHPStan - PHP Static Analysis Tool 2.2.11 Pass reported Lv.7+ 
regressions_object_property_discriminant_narrowing.php:35: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox. [reported-from-level=7]
regressions_object_property_discriminant_narrowing.php:43: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox. [reported-from-level=7]
With strict-rules
regressions_object_property_discriminant_narrowing.php:35: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox.
regressions_object_property_discriminant_narrowing.php:43: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox.
psalm 6.16.1Psalm 6.16.1@f1f5de594dc76faf8784e02d3dc4716c91c6f6ac
next: 7.0.0-beta19		 Pass (pzoom≠) 
regressions_object_property_discriminant_narrowing.php:32: The declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick is incorrect, got 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' [InvalidReturnType]
regressions_object_property_discriminant_narrowing.php:35: The inferred type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' does not match the declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick [InvalidReturnStatement]
regressions_object_property_discriminant_narrowing.php:41: The declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion is incorrect, got 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' [InvalidReturnType]
regressions_object_property_discriminant_narrowing.php:43: The inferred type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' does not match the declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion [InvalidReturnStatement]
pzoom (Psalm port)
regressions_object_property_discriminant_narrowing.php:35: The type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox does not match the declared return type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox [InvalidReturnStatement]
regressions_object_property_discriminant_narrowing.php:43: The type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox does not match the declared return type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox [InvalidReturnStatement]
mago 1.47.4mago 1.47.4 Pass 
regressions_object_property_discriminant_narrowing.php:43: Invalid return type for function `Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion`: expected `Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox`, but found `Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox`. [invalid-return-statement]
mir 0.72.1mir 0.72.1 Fail 
regressions_object_property_discriminant_narrowing.php:34: RedundantCondition: Condition is always true/false for type 'bool' [MIR0400]
regressions_object_property_discriminant_narrowing.php:38: UnreachableCode: Unreachable code detected [MIR0502]
Expectation diff
Line 43: Expected 1 error(s)
phpantom 0.10.0phpantom_lsp 0.10.0 Pass 
regressions_object_property_discriminant_narrowing.php:43: Return type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox is incompatible with declared return type Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox [type_mismatch_return]
intelephense 1.18.5intelephense 1.18.5 Pass 
regressions_object_property_discriminant_narrowing.php:35: Expected type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox'. Found 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox'. [P1006]
regressions_object_property_discriminant_narrowing.php:43: Expected type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox'. Found 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox'. [P1006]
phpactor 2026.07.22.0Phpactor 2026.07.22.0 Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
phpy 0.2.0phpy 0.2.0 Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
qodana 262.9437.196Qodana 262.9437.196 Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
noverify 0.5.5NoVerify, version 0.5.5: built on: 2025.04.22 14:36:46 OS: r-kuchinskas arm64 Commit: 4774b82f8adc53fbef38f95e97af4b953b4d1529 Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
steins 0.1.6steins 0.1.6 (2026-08-25 revision c13b4c7) Fail

No diagnostics reported.

Expectation diff
Line 43: Expected 1 error(s)
phpstan-strict 2.2.11PHPStan - PHP Static Analysis Tool 2.2.11 Pass 
regressions_object_property_discriminant_narrowing.php:35: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox.
regressions_object_property_discriminant_narrowing.php:43: Function Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion() should return Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox but returns Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox.
psalm-next 7.0.0-beta19Psalm 7.0.0-beta19@7e751c06a756fa64dc4c759c09fe4a173afcb433 Pass 
regressions_object_property_discriminant_narrowing.php:32: The declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick is incorrect, got 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' [InvalidReturnType]
regressions_object_property_discriminant_narrowing.php:35: The inferred type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' does not match the declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\pick [InvalidReturnStatement]
regressions_object_property_discriminant_narrowing.php:41: The declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion is incorrect, got 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' [InvalidReturnType]
regressions_object_property_discriminant_narrowing.php:43: The inferred type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\IntBox|Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' does not match the declared return type 'Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\StrBox' for Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing\stillUnion [InvalidReturnStatement]

Source

<?php

declare(strict_types=1);

namespace Conformance\Tests\RegressionsObjectPropertyDiscriminantNarrowing;

/**
 * Narrowing an object union by a discriminating property.
 *
 * `StrBox::$v` is `string` and `IntBox::$v` is `int`, so `is_string($b->v)` holds only for
 * `StrBox`. In that branch `$b` is `StrBox` and `return $b` satisfies the `: StrBox` return
 * type. Analyzers diverge on whether they narrow the *object* union from a check on a
 * discriminating property.
 *
 * PHPStan narrows array-shape discriminated unions (`$a['tag'] === true`) but not the object
 * equivalent (`is_string($b->v)` / `$b->tag === true`), so it keeps `StrBox|IntBox` here and
 * reports a false-positive return.type.
 *
 * Source lead: Mago analyzer test `issue_1093` (`test_property_narrowing`).
 */

final class StrBox
{
    public string $v = '';
}

final class IntBox
{
    public int $v = 0;
}

function pick(StrBox|IntBox $b): StrBox // E<psalm>: declares the return invalid because $b is not narrowed to StrBox (InvalidReturnType)
{
    if (is_string($b->v)) { // E<mir>: over-narrows, so the discriminator is redundant
        return $b; // E<phpstan>: does not narrow the object union from is_string($b->v), so keeps StrBox|IntBox and reports return.type // E<phpstan-strict>: same // E<psalm>: InvalidReturnStatement // E<pzoom>: same return-type mismatch as Psalm // E<intelephense>: same StrBox|IntBox on the return. Mago narrows to StrBox and stays clean. Phan is silent on the unguarded return too, so it never checked
    }

    throw new \LogicException('not a StrBox'); // E?<mir>: unreachable after the over-narrowing
}

function stillUnion(StrBox|IntBox $b): StrBox // E<psalm>: InvalidReturnType on the unguarded return, same finding as pick
{
    return $b; // E: StrBox|IntBox is not StrBox — silence on pick() is narrowing only if this line reports
}