← All results

Property-hook bodies on constructor-promoted properties

Group: Properties · Category: language · File: properties_promoted_property_hook_body.php

A set hook on a promoted property is still a function body: a type mismatch inside it should be reported the same way it would on a non-promoted hooked property. Mago 1.47 started analysing these bodies (carthage-software/mago#2218); before that the hook was skipped. References: - PHP language: constructor property promotion + property hooks - mago#2218

Analyzer results

AnalyzerVersionResultDiagnostics
phan 6.0.10Phan 6.0.10 php-ast version 1.1.3 PHP version used to run Phan: 8.5.11 Pass 
properties_promoted_property_hook_body.php:33: Argument 1 ($value) is $value of type int but \Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString() takes string defined at /Users/megurine/repo/php/php-typing-conformance/conformance/tests/properties_promoted_property_hook_body.php:20 [PhanTypeMismatchArgumentReal]
properties_promoted_property_hook_body.php:44: Argument 1 ($value) is $value of type int but \Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString() takes string defined at /Users/megurine/repo/php/php-typing-conformance/conformance/tests/properties_promoted_property_hook_body.php:20 [PhanTypeMismatchArgumentReal]
phpstan 2.3.1PHPStan - PHP Static Analysis Tool 2.3.1 Pass reported Lv.5+ 
properties_promoted_property_hook_body.php:33: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given. [reported-from-level=5]
properties_promoted_property_hook_body.php:44: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given. [reported-from-level=5]
With strict-rules
properties_promoted_property_hook_body.php:33: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given.
properties_promoted_property_hook_body.php:44: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given.
psalm 6.20.0Psalm 6.20.0@804f03c0c183d149fcd4b8c7c0c9b3fbf836d34c
next: 7.0.0-rc2		 Fail

No diagnostics reported.

Expectation diff
Line 33: Expected 1 error(s)
Line 44: Expected 1 error(s)
mago 1.57.0mago 1.57.0 Pass 
properties_promoted_property_hook_body.php:33: Invalid argument type for argument #1 of `Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString`: expected `string`, but found `int`. [invalid-argument]
properties_promoted_property_hook_body.php:44: Invalid argument type for argument #1 of `Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString`: expected `string`, but found `int`. [invalid-argument]
mir 0.87.0mir 0.87.0 Pass 
properties_promoted_property_hook_body.php:33: InvalidArgument: Argument $value of takesString() expects 'string', got 'int' [MIR0201]
properties_promoted_property_hook_body.php:44: InvalidArgument: Argument $value of takesString() expects 'string', got 'int' [MIR0201]
phpantom 0.11.1phpantom_lsp 0.11.1 Pass 
properties_promoted_property_hook_body.php:33: Argument 1 ($value) expects string, got int [type_mismatch_argument]
properties_promoted_property_hook_body.php:44: Argument 1 ($value) expects string, got int [type_mismatch_argument]
intelephense 1.18.5intelephense 1.18.5 Pass 
properties_promoted_property_hook_body.php:33: Expected type 'string'. Found 'int'. [P1006]
properties_promoted_property_hook_body.php:44: Expected type 'string'. Found 'int'. [P1006]
phpactor 2026.10.07.0Phpactor 2026.10.07.0 Fail 
properties_promoted_property_hook_body.php:32: Function "set" not found [unresolved_name]
properties_promoted_property_hook_body.php:54: Function "set" not found [unresolved_name]
Expectation diff
Line 33: Expected 1 error(s)
Line 44: Expected 1 error(s)
Line 32: Unexpected errors ["Function \"set\" not found [unresolved_name]"]
Line 54: Unexpected errors ["Function \"set\" not found [unresolved_name]"]
phpy 1.0.19409phpy 1.0.19409 Fail 
properties_promoted_property_hook_body.php:44: Argument '1' passed to Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString() is expected to be of type string, int given
Expectation diff
Line 33: Expected 1 error(s)
qodana 262.10968.76PhpStorm 262.10968.76 Pass 
properties_promoted_property_hook_body.php:33: Parameter '$value' type is not compatible with declaration when using strict type matching [PhpParamsInspection]
properties_promoted_property_hook_body.php:33: Parameter '$value' type is not compatible with declaration [PhpStrictTypeCheckingInspection]
properties_promoted_property_hook_body.php:44: Parameter '$value' type is not compatible with declaration when using strict type matching [PhpParamsInspection]
properties_promoted_property_hook_body.php:44: Parameter '$value' type is not compatible with declaration [PhpStrictTypeCheckingInspection]
noverify 0.5.5NoVerify, version 0.5.5: built on: 2025.04.22 14:36:46 OS: r-kuchinskas arm64 Commit: 4774b82f8adc53fbef38f95e97af4b953b4d1529 Fail

No diagnostics reported.

Expectation diff
Line 33: Expected 1 error(s)
Line 44: Expected 1 error(s)
steins 0.1.8steins 0.1.8 (2026-09-21 revision 76306a9) Fail

No diagnostics reported.

Expectation diff
Line 33: Expected 1 error(s)
Line 44: Expected 1 error(s)
phpstan-strict 2.3.1PHPStan - PHP Static Analysis Tool 2.3.1 Pass 
properties_promoted_property_hook_body.php:33: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given.
properties_promoted_property_hook_body.php:44: Parameter #1 $value of function Conformance\Tests\PropertiesPromotedPropertyHookBody\takesString expects string, int given.
psalm-next 7.0.0-rc2Psalm 7.0.0-rc2@20339e3fe5b8d03bcd8061030eb2a83ad50e5783 Fail

No diagnostics reported.

Expectation diff
Line 33: Expected 1 error(s)
Line 44: Expected 1 error(s)

Source

<?php

declare(strict_types=1);

namespace Conformance\Tests\PropertiesPromotedPropertyHookBody;

/**
 * Property-hook bodies on constructor-promoted properties.
 *
 * A set hook on a promoted property is still a function body: a type
 * mismatch inside it should be reported the same way it would on a
 * non-promoted hooked property. Mago 1.47 started analysing these bodies
 * (carthage-software/mago#2218); before that the hook was skipped.
 *
 * References:
 * - PHP language: constructor property promotion + property hooks
 * - https://github.com/carthage-software/mago/issues/2218
 */

function takesString(string $value): void
{
}

function takesInt(int $value): void
{
}

final class Promoted
{
    public function __construct(
        public int $value {
            set(int $value) {
                takesString($value); // E: int is not string
            }
        },
    ) {
    }
}

final class Regular
{
    public int $value = 0 {
        set(int $value) {
            takesString($value); // E: the same mismatch, not promotion-specific
            $this->value = $value;
        }
    }
}

final class PromotedOk
{
    public function __construct(
        public int $value {
            set(int $value) {
                takesInt($value); // V
            }
        },
    ) {
    }
}